Skip to content

Conversation

@akaltar
Copy link
Contributor

@akaltar akaltar commented Nov 2, 2025

Description

As discussed here: #8149
I've updated the docs to include a callout to the V8 stack trace limit feature, and to mention that the stack trace filtering doesn't apply to regular console logs that might get printed by printConsoleTrace
I've tried to fix the latter by calling the appropriate filtering functions, but it looks like printConsoleTrace is implemented in workers, which only have access to the serialized config, which of course lacks the onStackTrace filtering function.

In the discussion we also talked about removing the .slice from this code path since it might limit the stack frames to the first 6, but after a second look I think it's doing the opposite, basically removing the first 6 stack frames that are vite internals in a transparent way, which I think probably helps make the stack frames more readable

PS If you know how could/should I add the filter function to the serialized config in workers, so it could apply to printConsoleTrace I'd be happy to have a go at it, but couldn't find examples of similar things in the config, and this seems like it could be a performance critical problem.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Nov 2, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b541110
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/690714fa54d4aa0008ed1972
😎 Deploy Preview https://deploy-preview-8905--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sheremet-va sheremet-va merged commit 2f37cce into vitest-dev:main Nov 2, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants