Skip to content

Conversation

@sheremet-va
Copy link
Member

Description

Resolves #8766

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@sheremet-va sheremet-va merged commit 3fae73e into vitest-dev:main Oct 22, 2025
12 of 14 checks passed
@sheremet-va sheremet-va deleted the fix/dont-close-rpc-too-soon branch October 22, 2025 15:28
@AriPerkkio
Copy link
Member

This is now leaking birpc listeners:

(node:45742) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 message listeners added to [process]. MaxListeners is 10. Use emitter.setMaxListeners() to increase limit
    at genericNodeError (node:internal/errors:983:15)
    at wrappedFn (node:internal/errors:537:14)
    at _addListener (node:events:592:17)
    at process.addListener (node:events:610:10)
    at on (file:///x/Git/ast-v8-to-istanbul/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected]/node_modules/vitest/dist/chunks/init-forks.WglB-sfY.js:15:7)
    at createBirpc (file:///x/Git/ast-v8-to-istanbul/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected]/node_modules/vitest/dist/chunks/index.Bgo3tNWt.js:164:14)
    at createRuntimeRpc (file:///x/Git/ast-v8-to-istanbul/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected]/node_modules/vitest/dist/chunks/rpc.cD77ENhU.js:31:22)

@sheremet-va
Copy link
Member Author

This is now leaking birpc listeners:

We need to clean it up before running the next test, like it was in v3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New pool implementation: Timeout terminating forks worker for test files (v4)

2 participants