Skip to content

Conversation

@btea
Copy link
Contributor

@btea btea commented Jun 7, 2025

Description

I think it is more friendly to specify the specific level of the projects field in the printed log information.

However, I also wonder if some users will misunderstand test.projects as a field. Look forward to your opinions.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to use this style, it should be applied here too:

this.logger.warn(
'Both `config.projects` and `config.workspace` are defined. Ignoring the `workspace` option.',
)

this.logger.deprecate(
'The `workspace` option is deprecated and will be removed in the next major. To hide this warning, rename `workspace` option to `projects`.',
)

@btea
Copy link
Contributor Author

btea commented Jun 11, 2025

Thanks for reviewing. Looking forward to other people's comments, if you agree with the changes, I will update them.

@sheremet-va
Copy link
Member

If we want to use this style, it should be applied here too:

this.logger.warn(
'Both `config.projects` and `config.workspace` are defined. Ignoring the `workspace` option.',
)

this.logger.deprecate(
'The `workspace` option is deprecated and will be removed in the next major. To hide this warning, rename `workspace` option to `projects`.',
)

I agree

@netlify
Copy link

netlify bot commented Jun 11, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 864b34f
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/68497b80a504db000854705c
😎 Deploy Preview https://deploy-preview-8118--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sheremet-va sheremet-va merged commit c0eae7d into vitest-dev:main Jun 11, 2025
12 of 14 checks passed
@btea btea deleted the chore/update-workspace-log branch June 11, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants