Skip to content

Conversation

@hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Mar 16, 2025

Description

Almost done by just mechanical find&replace 😄

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Mar 16, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c36d476
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/67d93f6ba69a8a000846824f
😎 Deploy Preview https://deploy-preview-7680--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hi-ogawa hi-ogawa marked this pull request as ready for review March 16, 2025 09:44
@AriPerkkio
Copy link
Member

/ecosystem-ci run

@vitest-ecosystem-ci
Copy link

vitest-ecosystem-ci bot commented Mar 18, 2025

📝 Ran ecosystem CI: Open

suite result
aria-live-capture ✅ success
vite ✅ success
lerna-lite ✅ success
elk ❌ failure
nuxt ❌ failure
vitest-browser-examples ✅ success
vitest-reporters-large ✅ success
vitest-coverage-large ✅ success
nuxt-test-utils ❌ failure
vitest-sonar-reporter ✅ success
vitest-benchmark-large ✅ success
effect ❌ failure
zustand ✅ success
vue ✅ success
vitest-vscode ✅ success

Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Ecosystem failures are on main too.

When can we use Rolldown directly? 🥲

@sheremet-va sheremet-va merged commit 9695d73 into vitest-dev:main Mar 18, 2025
21 of 22 checks passed
@hi-ogawa hi-ogawa deleted the chore-more-oxc branch March 18, 2025 23:00
@hi-ogawa
Copy link
Contributor Author

When can we use Rolldown directly? 🥲

rollup-plugin-dts isn't possible on rolldown, so we need to explore a way to ship unbundled .d.ts first. Otherwise, we'll still need rollup + rollup-plugin-dts as a post build of rolldown, which is what tsdown https://github.com/sxzz/tsdown does, we could try that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants