feat: add support for custom vitest imports #793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veritem
requested changes
Oct 17, 2025
Member
veritem
left a comment
veritem
left a comment
There was a problem hiding this comment.
this is good work. mind running format command for me?
Contributor
Author
|
Thanks, I fixed the formatting |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we use custom fixtures in a separate file and import
testfrom there instead ofvitest, many rules don't work properly anymore because they expect the functions being imported fromvitest. This PR adds a newvitestImportssetting that allows specifying additional import patterns that will be detected as Vitest import. I added a few tests for thevalid-titlerule but I can add tests to other rules as well if needed.Do you think that's a viable approach?
Thanks for reviewing 🙏