Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions src/rules/prefer-importing-vitest-globals.ts
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,29 @@ export default createEslintRule<Options, MESSAGE_IDS>({
const name = node.callee.name
if (importedNames.has(name)) return

const scope = context.sourceCode.getScope(node)
const variable = scope.set.get(name)

if (variable && variable.defs.length > 0) {
const hasTrueLocalBinding = variable.defs.some((def) => {
if (def.type === 'ImportBinding') {
return false
}
if (
def.type === 'Variable' &&
def.node.init &&
isRequireVitestCall(def.node.init)
) {
return false
}
return true
})

if (hasTrueLocalBinding) {
return
}
}

context.report({
node: node.callee,
messageId: 'preferImportingVitestGlobals',
Expand Down
3 changes: 3 additions & 0 deletions tests/prefer-importing-vitest-globals.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ ruleTester.run(RULE_NAME, rule, {
"const { describe } = require('vitest'); describe('suite', () => {});",
"const { describe, it } = require('vitest'); describe('suite', () => {});",
"const { describe, describe } = require('vitest'); describe('suite', () => {});",
"import { describe, expect, it } from 'vitest'; describe('suite', () => { it('test', () => { let test = 5; expect(test).toBe(5); }); });",
"import { describe, expect, it } from 'vitest'; describe('suite', () => { it('test', () => { const test = () => true; expect(test()).toBe(true); }); });",
"import { describe, expect, it } from 'vitest'; describe('suite', () => { it('test', () => { function fn(test) { return test; } expect(fn(5)).toBe(5); }); });",
],
invalid: [
{
Expand Down