Skip to content

Conversation

@driimus
Copy link
Contributor

@driimus driimus commented Apr 8, 2024

Fixes #413 by replacing all the context methods which have been deprecated in eslint v8, and subsequently removed in v9 or are slated for removal in v10 (outlined in this blog post).

The supported eslint versions all have the new syntax:
https://github.com/veritem/eslint-plugin-vitest/blob/76f00f604308e3ad3cd5fe3bdd302a1262b6ee1f/package.json#L70
Therefore it's safe to use the replacement methods directly, without a fallback to the old methods (which they showcase in the blog post for backwards compatibility).

@driimus driimus marked this pull request as ready for review April 8, 2024 12:54
Copy link
Member

@veritem veritem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks!!!!

@veritem veritem merged commit 575951c into vitest-dev:main Apr 8, 2024
@zemd zemd mentioned this pull request May 12, 2024
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Throwing with ESLint 9 and flat config

2 participants