Skip to content

fix(ssr): ssrTransfrom with function declaration in scope, fix #4306 #5376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2021
Merged

fix(ssr): ssrTransfrom with function declaration in scope, fix #4306 #5376

merged 2 commits into from
Oct 21, 2021

Conversation

@patak-dev
Copy link
Member

@patak-dev patak-dev commented Oct 21, 2021

Description

See #4306 and added test cases for details. Shadowing for variable declarations was already taken into account, but not for function declarations.

Error for the test case before this PR for reference
image

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@patak-dev patak-dev added feat: ssr p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) p4-important Violate documented behavior or significantly improves performance (priority) and removed p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) labels Oct 21, 2021
@patak-dev patak-dev linked an issue Oct 21, 2021 that may be closed by this pull request
ESM Modules: ssrTransform blindly overwrites all functions named as an import instead of checking for a locally scoped function with the same name #4306
Closed
6 tasks
patak-dev
patak-dev commented Oct 21, 2021
View reviewed changes
@antfu antfu merged commit 5306632 into main Oct 21, 2021
@antfu antfu deleted the fix/ssr-transform-scopes branch October 21, 2021 21:17
@benmccann benmccann mentioned this pull request Oct 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@aleclarson aleclarson aleclarson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feat: ssr p4-important Violate documented behavior or significantly improves performance (priority)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ESM Modules: ssrTransform blindly overwrites all functions named as an import instead of checking for a locally scoped function with the same name

4 participants

@patak-dev @aleclarson @antfu