Skip to content

fix: avoid scan failures in .svelte and .astro files #5193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 11, 2021
Merged

fix: avoid scan failures in .svelte and .astro files #5193

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
393ca10
fix: avoid scan failures in .svelte and .astro files
benmccann Oct 4, 2021
b2221bc
fix: update from code review
benmccann Oct 8, 2021
4ed66ff
Update packages/vite/src/node/optimizer/scan.ts
benmccann Oct 8, 2021
90f10a9
swap order of checks for performance
benmccann Oct 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/vite/src/node/optimizer/scan.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,8 +265,16 @@ function esbuildScanPlugin(
}
}

if (!code.includes(`export default`)) {
js += `\nexport default {}`
// This will trigger incorrectly if `export default` is contained
// anywhere in a string/template. Svelte files can't have
// 'export default` as code so we know if it's encountered it's a
// false positive
if (
!code.includes('export default') ||
path.endsWith('.svelte') ||
path.endsWith('.astro')
) {
js += '\nexport default {}'
}

if (code.includes('import.meta.glob')) {
Expand Down