Skip to content

fix: better error message for parse failures #5192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 5, 2021
Merged

fix: better error message for parse failures #5192

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
458a175
fix: better error message for parse failures
benmccann Oct 4, 2021
570f1f3
fix: less verbose error message
benmccann Oct 4, 2021
225756a
fix: check that loc exists
benmccann Oct 5, 2021
24cfd04
fix: add check for err.loc.line as well
benmccann Oct 5, 2021
d4e846f
refactor: change location of any
benmccann Oct 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions packages/vite/src/node/ssr/ssrTransform.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,22 @@ export async function ssrTransform(
): Promise<TransformResult | null> {
const s = new MagicString(code)

const ast = parser.parse(code, {
sourceType: 'module',
ecmaVersion: 'latest',
locations: true
}) as any
let ast
try {
ast = parser.parse(code, {
sourceType: 'module',
ecmaVersion: 'latest',
locations: true
}) as any
} catch (err) {
if (!err.loc || !err.loc.line) throw err
const line = err.loc.line
throw new Error(
`Parse failure: ${err.message}\nContents of line ${line}: ${
code.split('\n')[line - 1]
}`
)
}

let uid = 0
const deps = new Set<string>()
Expand Down