fix(css): respect emitAssets when cssCodeSplit=false

[lucalooz]

Fixes #15196

Description

vite:css-post is placed after vite:asset which cleans up assets in the generateBundle phase.

vite:css-post emits assets inside renderChunk but also in the generateBundle phase for cssCodeSplit=false, which is AFTER vite:asset execution.

So it's vite:css-post responsibility to respect the emitAssets config.

[sapphi-red]

I think we still need to run this part:

vite/packages/vite/src/node/plugins/css.ts

Lines 1014 to 1083 in bcecf6d

	// remove empty css chunks and their imports
	if (pureCssChunks.size) {
	// map each pure css chunk (rendered chunk) to it's corresponding bundle
	// chunk. we check that by `preliminaryFileName` as they have different
	// `filename`s (rendered chunk has the !~{XXX}~ placeholder)
	const prelimaryNameToChunkMap = Object.fromEntries(
	Object.values(bundle)
	.filter((chunk): chunk is OutputChunk => chunk.type === 'chunk')
	.map((chunk) => [chunk.preliminaryFileName, chunk.fileName]),
	)
	// When running in watch mode the generateBundle is called once per output format
	// in this case the `bundle` is not populated with the other output files
	// but they are still in `pureCssChunks`.
	// So we need to filter the names and only use those who are defined
	const pureCssChunkNames = [...pureCssChunks]
	.map((pureCssChunk) => prelimaryNameToChunkMap[pureCssChunk.fileName])
	.filter(Boolean)
	const replaceEmptyChunk = getEmptyChunkReplacer(
	pureCssChunkNames,
	opts.format,
	)
	for (const file in bundle) {
	const chunk = bundle[file]
	if (chunk.type === 'chunk') {
	let chunkImportsPureCssChunk = false
	// remove pure css chunk from other chunk's imports,
	// and also register the emitted CSS files under the importer
	// chunks instead.
	chunk.imports = chunk.imports.filter((file) => {
	if (pureCssChunkNames.includes(file)) {
	const { importedCss, importedAssets } = (
	bundle[file] as OutputChunk
	).viteMetadata!
	importedCss.forEach((file) =>
	chunk.viteMetadata!.importedCss.add(file),
	)
	importedAssets.forEach((file) =>
	chunk.viteMetadata!.importedAssets.add(file),
	)
	chunkImportsPureCssChunk = true
	return false
	}
	return true
	})
	if (chunkImportsPureCssChunk) {
	chunk.code = replaceEmptyChunk(chunk.code)
	}
	}
	}
	const removedPureCssFiles = removedPureCssFilesCache.get(config)!
	pureCssChunkNames.forEach((fileName) => {
	removedPureCssFiles.set(fileName, bundle[fileName] as RenderedChunk)
	delete bundle[fileName]
	delete bundle[`${fileName}.map`]
	})
	}
	const cssAssets = Object.values(bundle).filter(
	(asset): asset is OutputAsset =>
	asset.type === 'asset' && asset.fileName.endsWith('.css'),
	)
	for (const cssAsset of cssAssets) {
	if (typeof cssAsset.source === 'string') {
	cssAsset.source = cssAsset.source.replace(viteHashUpdateMarkerRE, '')
	}
	}

To fix that, would you move the condition in this if?

vite/packages/vite/src/node/plugins/css.ts

Line 967 in bcecf6d

if (!this.environment.config.build.cssCodeSplit && !hasEmitted) {

[sapphi-red]

Thanks