Skip to content

fix(css): handle lightningcss compiled css in Deno #17301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2024
Merged

fix(css): handle lightningcss compiled css in Deno #17301

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7106cc9
fix: convert css code to buffer
May 24, 2024
0475120
fix: decode compiled lightlingcss code using `TextDecoder`
May 27, 2024
a96b07a
fix: hoist the initialization `TextDecoder` instance from `compileLin…
May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/vite/src/node/plugins/css.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2695,6 +2695,7 @@ function isPreProcessor(lang: any): lang is PreprocessLang {

const importLightningCSS = createCachedImport(() => import('lightningcss'))

const decoder = new TextDecoder()
async function compileLightningCSS(
id: string,
src: string,
Expand Down Expand Up @@ -2760,7 +2761,10 @@ async function compileLightningCSS(
: undefined,
})

let css = res.code.toString()
// NodeJS res.code = Buffer
// Deno res.code = Uint8Array
// For correct decode compiled css need to use TextDecoder
let css = decoder.decode(res.code)
for (const dep of res.dependencies!) {
switch (dep.type) {
case 'url':
Expand Down