fix(scan): handle html script tag attributes that contain ">" #13101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s ">" The case occurs with Vue 3 generics usage but is technically possible in other scenarios as well ref: vuejs/core#8171
|
|
Member
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI: Open
|
patak-dev
approved these changes
May 5, 2023
Member
patak-dev
left a comment
patak-dev
left a comment
There was a problem hiding this comment.
ecosystem-ci is good, Nuxt and vite-plugin-ssr are currently failing against main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The case occurs with Vue 3 generics usage but is technically possible in other scenarios as well. E.g. for
<script foo=">">console.log(1)</script>, the previous regex matches">console.log(1)as the script content and causes a esbuild parse error.ref: vuejs/core#8171
This PR uses a more complex regex that accounts for arbitrary attributes on the
<script tag>. Also refactored the logic to use a single regex for both HTML and HTML-like file types.