-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
Closed
Labels
contribution welcomep3-minor-bugAn edge case that only affects very specific usage (priority)An edge case that only affects very specific usage (priority)
Description
Describe the bug
The response returned from the error middleware uses a hard coded import to @vite/client, even when server.origin or base config options are set.
Expected behavior would be that the import would include those config options when set.
Reproduction
https://stackblitz.com/edit/vitejs-vite-lp39cj
Steps to reproduce
- View the reproduction URL above.
- Change the URL to
/foo/error - Observe the embedded Vite error overlay import has the incorrect path to the
@vite/client
System Info
System:
OS: Linux 5.0 undefined
CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
Memory: 0 Bytes / 0 Bytes
Shell: 1.0 - /bin/jsh
Binaries:
Node: 18.20.3 - /usr/local/bin/node
Yarn: 1.22.19 - /usr/local/bin/yarn
npm: 10.2.3 - /usr/local/bin/npm
pnpm: 8.15.6 - /usr/local/bin/pnpm
npmPackages:
vite: ^5.3.2 => 5.3.3Used Package Manager
npm
Logs
No response
Validations
- Follow our Code of Conduct
- Read the Contributing Guidelines.
- Read the docs.
- Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
- Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
- Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
- The provided reproduction is a minimal reproducible example of the bug.
txantslusam
Metadata
Metadata
Assignees
Labels
contribution welcomep3-minor-bugAn edge case that only affects very specific usage (priority)An edge case that only affects very specific usage (priority)