fix: override @type/node to ensure consistent types
#85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`@types/node` is actually an implicit peer dependency of Vite. So I overrode it with the version from the Vite project dependencies. This fixes the most recent iles CI failure.
patak-dev
approved these changes
Jun 28, 2022
|
Thanks a lot, Soda! Running vite-ecosystem-ci with this on now: https://github.com/vitejs/vite-ecosystem-ci/actions/runs/2577855796 Looks like @DylanPiercey was having the same issue in Marko |
haoqunjiang
added a commit
to haoqunjiang/vite
that referenced
this pull request
Nov 2, 2022
The built bundle of Vite starts with a reference to `node` types: https://unpkg.com/browse/[email protected]/dist/node/index.d.ts This means those who depend on Vite type definitions should install `@types/node` in their projects to successfully do type-checking. In that sense, `@types/node` is an optional peer dependency of Vite. After this being fixed, we should revert vitejs/vite-ecosystem-ci#85 because not explicitly depending on `@types/node` *should* be erroneous. The ecosystem CI shouldn't cover that error for downstream packages.
9 tasks
patak-dev
pushed a commit
to vitejs/vite
that referenced
this pull request
Nov 4, 2022
The built bundle of Vite starts with a reference to `node` types: https://unpkg.com/browse/[email protected]/dist/node/index.d.ts This means those who depend on Vite type definitions should install `@types/node` in their projects to successfully do type-checking. In that sense, `@types/node` is an optional peer dependency of Vite. After this being fixed, we should revert vitejs/vite-ecosystem-ci#85 because not explicitly depending on `@types/node` *should* be erroneous. The ecosystem CI shouldn't cover that error for downstream packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@types/nodeis actually an implicit peer dependency of Vite.So I overrode it with the version from the Vite project dependencies.
This fixes the most recent iles CI failure.