Skip to content

Conversation

@tonistiigi
Copy link
Contributor

Signed-off-by: Tonis Tiigi [email protected]

Signed-off-by: Tonis Tiigi <[email protected]>
Copy link
Contributor

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, SYS_NETNS from golang.org/x/sys/unix (which is already a dependency) could be used to replace this, i.e.

import "golang.org/x/sys/unix"
...
var SYS_SETNS = unix.SYS_SETNS

@tonistiigi
Copy link
Contributor Author

tonistiigi commented Jun 10, 2019

I'm not sure if this package wants to have a dependency on x/sys. Afaics it doesn't currently have any dependencies.

cc @vishvananda

@tklauser
Copy link
Contributor

Ah, right. I somehow assumed that this package already depends on x/sys but this isn't the case. Feel free to disregard my comment.

@carlosedp
Copy link

Any news on this guys?

@aboch
Copy link
Collaborator

aboch commented Jun 25, 2019

LGTM

@vishvananda vishvananda merged commit a1b8f1f into vishvananda:master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants