Skip to content

Conversation

@fearthecowboy
Copy link

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

gimotwanMSFT pushed a commit that referenced this pull request May 25, 2018
Azure#3090)

* Merged PR 17875: Add new languages

Add new languages

Also tidy up the enum definition so that AutoRest generates C# that actually compiles

* Merged PR 17942: Replace fancy quotes with plain single quotes

Make javac compile without complaint even without setting the codepage to utf-8 by dropping the gratuitous typographic quotes.

* Merged PR 17956: Rename url argument for overloaded endpoint to imageUrl

This name will become the name of the argument in Python.  Since you can used named arguments in Python, give them less ambiguous names.

* Changes to make --azure-validator run more cleanly

Errors Fixed
* XmsExamplesRequired/D5001/Documentation (7)
* XmsPathsMustOverloadPaths/R2058/SDKViolation (7)

Errors Ignored
* SecurityDefinitionsStructure/R2054/SDKViolation (1) - API Key scheme for Cognitive Services
* APIVersionPattern/R3012/ARMViolation (1) - Keeping with the Cognitive Services numbering scheme
* OperationsAPIImplementation/R3023/ARMViolation (1) - Not sure what this is

Warnings Fixed
* XmsEnumValidation/R2018/SDKViolation (1)
* DescriptionAndTitleMissing/R4000/SDKViolation (1)

Warnings Ignored
* DescriptionAndTitleMissing/R4000/SDKViolation (35) - description is contained in #ref
* EnumInsteadOfBoolean/R3018/ARMViolation (5) - fix would be a breaking change
* ListInOperationName/R1003/SDKViolation (1) - fix would be a breaking change
* LongRunningOperationsWithLongRunningExtension/R2007/SDKViolation (2) - endpoint will not ultimately yield a 200, as this extension would require
* NonApplicationJsonType/R2004/ARMViolation (15) - fix would be breaking change
* PageableOperation/R2029/SDKViolation (1) - not actually pageable
* ParameterNotDefinedInGlobalParameters/R2015/SDKViolation (1) - All our own parameters specify x-ms-parameter-location
* PostOperationIdContainsUrlVerb/R2066/SDKViolation (7) - fix would be breaking change
vinayada1 pushed a commit that referenced this pull request Mar 13, 2020
* 2019-08-09-preview

* spell out networks

* username and credential needed to add an IdentitySource

* post listAdminCredentials

* standardize on username, password, nsxt and vcenter

* add nsxt to custom-words.txt

* default cluster does not have provisioningState

* it extends DefaultClusterProperties

* add Circuit expressRoutePrivatePeeringID

* back out some minor changes for sdk generation

* identitySources and Circuit authorizations are updateable

* add PrivateClouds_ListInSubscription

* Long running operation for Clusters_Delete (#1)

* npm run prettier

* location for all resources (Azure#2)

* Revert "location for all resources (Azure#2)" (Azure#3)

This reverts commit 432e37b.

* add description TODOs

* example is PrivateClouds_Update

* require body in PrivateClouds_Update

* replaced TODOs with descriptions

* spellcheck

* "x-ms-secret": true

* Revert ""x-ms-secret": true"

This reverts commit 3358dff.

Co-authored-by: Andrew Ulliani <[email protected]>
Co-authored-by: Eugene Tolmachev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant