-
-
Notifications
You must be signed in to change notification settings - Fork 33
🌿 Add test for import_map.jsonc support #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds JSONC import map test coverage: updates deno.jsonc excludes, introduces test data (helper and plugin using import_map.jsonc), and extends the plugin test to load and verify the JSONC-mapped imports and dispatcher behavior. Changes
Sequence Diagram(s)sequenceDiagram
participant Test as Plugin Test
participant Loader as Plugin Loader
participant Denops as Denops (mock)
participant Plugin as Plugin (import_map.jsonc)
Test->>Loader: load(scriptWithImportMapJsonc)
Loader->>Denops: emit PluginPre
Loader->>Plugin: main(denops)
Plugin->>Denops: dispatcher.test = (…)
Plugin->>Denops: cmd("Import map jsonc plugin initialized")
Loader->>Denops: emit PluginPost
Test->>Denops: call plugin.call("test")
Denops->>Plugin: dispatcher.test()
Plugin->>Denops: cmd(getMessage("test-plugin"))
Plugin-->>Test: return greeting
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
🧰 Additional context used🧠 Learnings (2)📓 Common learnings📚 Learning: 2024-09-14T17:09:30.174ZApplied to files:
🧬 Code Graph Analysis (2)tests/denops/testdata/with_import_map_jsonc/plugin_with_import_map_jsonc.ts (1)
denops/@denops-private/plugin_test.ts (2)
🔇 Additional comments (5)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #455 +/- ##
=======================================
Coverage 96.77% 96.77%
=======================================
Files 11 11
Lines 962 962
Branches 143 143
=======================================
Hits 931 931
Misses 28 28
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Ah, I didn't realized that I've added |
Add missing tests.
Summary by CodeRabbit