Skip to content

Grouped errors-only logs, show empty groups #10739

@moliva

Description

@moliva

Verify canary release

  • I verified that the issue exists in the latest Turborepo canary release.

Link to code that reproduces this issue

https://github.com/moliva/errors-only-logs-issue

Which canary version will you have in your reproduction?

2.5.6-canary.0

Environment information

(This could vary as the target environment is GitHub action runners)

CLI:
   Version: 2.5.6-canary.0
   Path to executable: /home/runner/work/errors-only-logs-issue/errors-only-logs-issue/node_modules/turbo-linux-64/bin/turbo
   Daemon status: Not running
   Package manager: npm

Platform:
   Architecture: x86_64
   Operating system: linux
   WSL: false
   Available memory (MB): 15046
   Available CPU cores: 4

Environment:
   CI: Some(
    "GitHub Actions",
)
   Terminal (TERM): unknown
   Terminal program (TERM_PROGRAM): unknown
   Terminal program version (TERM_PROGRAM_VERSION): unknown
   Shell (SHELL): /bin/bash
   stdin: true

Expected behavior

Running the command npx turbo test --continue=always --log-order=grouped --output-logs=errors-only should not show any logs nor collapsable groups from a non errored process in GitHub.

Actual behavior

I see collapsable groups in GitHub actions for processes that have not errored. I can assert that as these groups are empty and they pollute the final output of the job. Link to the workflow output here.

It may seem little as is, but having many packages running tests depending on other packages with dependent tasks (e.g. building the code first for each of them and running their tests), it quickly fills the output with empty collapsable groups that do not add any information.

Also note that the groups with errors cannot be collapsed.

Image

Note: this empty collapsable groups only appear in GitHub, not in a local terminal. In a terminal the only output shown is for errored processes.

To Reproduce

  • Fork the current repo in GitHub
  • Let it run the workflow defined
  • Check the results where there are collapsable groups of logs empty as they do not have any errors

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind: bugSomething isn't workingneeds: triageNew issues get this label. Remove it after triage

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions