Skip to content

Upgrade React from 7283a213-20241206 to 372ec00c-20241209 #73749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 18, 2024
Merged

Upgrade React from 7283a213-20241206 to 372ec00c-20241209 #73749

merged 6 commits into from
Dec 18, 2024

Conversation

@vercel-release-bot
Copy link
Contributor

@vercel-release-bot vercel-release-bot commented Dec 10, 2024

@ijjk ijjk added CI approved Approve running CI for fork type: next labels Dec 10, 2024
@ijjk
Copy link
Member

ijjk commented Dec 10, 2024 •
edited
Loading

Failing test suites

Commit: 0a92bfc

pnpm test-dev-turbo test/development/acceptance/ReactRefreshRequire.test.ts (turbopack)

  • ReactRefreshRequire > propagates a hot update to closest accepted module
Expand output

● ReactRefreshRequire › propagates a hot update to closest accepted module

expect(received).toEqual(expected) // deep equality

Expected: ["init FooV1", "init BarV1"]
Received: undefined

   95 |     )
   96 |
>  97 |     expect(await session.evaluate(() => (window as any).log)).toEqual([
      |                                                               ^
   98 |       'init FooV1',
   99 |       'init BarV1',
  100 |     ])

  at Object.toEqual (development/acceptance/ReactRefreshRequire.test.ts:97:63)

Read more about building and testing Next.js in contributing.md.

__NEXT_EXPERIMENTAL_PPR=true pnpm test-dev test/e2e/app-dir/actions/app-action.test.ts (PPR)

  • app-dir action handling > should forward action request to a worker that contains the action handler (node)
Expand output

● app-dir action handling › should forward action request to a worker that contains the action handler (node)

page.waitForSelector: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('#other-page')

  423 |     return this.chain(() => {
  424 |       return page
> 425 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  426 |         .then(async (el) => {
  427 |           // it seems selenium waits longer and tests rely on this behavior
  428 |           // so we wait for the load event fire before returning

  at waitForSelector (lib/browsers/playwright.ts:425:10)
  at e2e/app-dir/actions/app-action.test.ts:862:7

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Dec 10, 2024 •
edited
Loading

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js update/react/372ec00c-20241209 Change
buildDuration 18.5s 16.4s N/A
buildDurationCached 15.6s 13.1s N/A
nodeModulesSize 416 MB 416 MB N/A
nextStartRea..uration (ms) 458ms 477ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js update/react/372ec00c-20241209 Change
1187-HASH.js gzip 52.4 kB 52.4 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js update/react/372ec00c-20241209 Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js update/react/372ec00c-20241209 Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js update/react/372ec00c-20241209 Change
_buildManifest.js gzip 749 B 746 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js update/react/372ec00c-20241209 Change
index.html gzip 522 B 523 B N/A
link.html gzip 538 B 537 B N/A
withRouter.html gzip 519 B 520 B N/A
Overall change 0 B 0 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js update/react/372ec00c-20241209 Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 205 kB 205 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js update/react/372ec00c-20241209 Change
middleware-b..fest.js gzip 672 B 668 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js update/react/372ec00c-20241209 Change
274-experime...dev.js gzip 322 B 322 B ✓
274.runtime.dev.js gzip 314 B 314 B ✓
app-page-exp...dev.js gzip 356 kB 356 kB N/A
app-page-exp..prod.js gzip 129 kB 129 kB N/A
app-page-tur..prod.js gzip 142 kB 142 kB N/A
app-page-tur..prod.js gzip 137 kB 137 kB N/A
app-page.run...dev.js gzip 346 kB 346 kB N/A
app-page.run..prod.js gzip 125 kB 125 kB N/A
app-route-ex...dev.js gzip 37.5 kB 37.5 kB ✓
app-route-ex..prod.js gzip 25.5 kB 25.5 kB ✓
app-route-tu..prod.js gzip 25.5 kB 25.5 kB ✓
app-route-tu..prod.js gzip 25.3 kB 25.3 kB N/A
app-route.ru...dev.js gzip 39.1 kB 39.1 kB N/A
app-route.ru..prod.js gzip 25.3 kB 25.3 kB N/A
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB ✓
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB ✓
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB ✓
pages-turbo...prod.js gzip 21.7 kB 21.7 kB ✓
pages.runtim...dev.js gzip 27.5 kB 27.5 kB ✓
pages.runtim..prod.js gzip 21.7 kB 21.7 kB ✓
server.runti..prod.js gzip 916 kB 916 kB N/A
Overall change 191 kB 191 kB ✓
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js update/react/372ec00c-20241209 Change
0.pack gzip 2.08 MB 2.08 MB N/A
index.pack gzip 74.1 kB 74.7 kB ⚠️ +602 B
Overall change 74.1 kB 74.7 kB ⚠️ +602 B
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js 
failed to diff
Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js 
failed to diff
Diff for app-page.runtime.prod.js

Diff too large to display

Diff for server.runtime.prod.js 
failed to diff
Commit: a192886

@socket-security
Copy link

socket-security bot commented Dec 10, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] environment 0 8.31 MB react-bot
npm/[email protected] environment 0 6.38 MB react-bot
npm/[email protected] environment 0 13.6 kB react-bot
npm/[email protected] None +1 1.37 MB react-bot
npm/[email protected] None +1 1.27 MB react-bot
npm/[email protected] None +1 1.84 MB react-bot
npm/[email protected] None +1 1.71 MB react-bot
npm/[email protected] environment 0 178 kB react-bot
npm/[email protected] environment 0 238 kB react-bot
npm/[email protected] environment 0 84.2 kB react-bot
npm/[email protected] environment 0 84.2 kB react-bot

🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

eps1lon
eps1lon approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The next one s where we need to make some changes.

@eps1lon eps1lon enabled auto-merge (squash) December 18, 2024 13:24
@eps1lon eps1lon force-pushed the update/react/372ec00c-20241209 branch from 0a92bfc to 014fd6c Compare December 18, 2024 13:24
@eps1lon eps1lon disabled auto-merge December 18, 2024 13:24
@eps1lon eps1lon enabled auto-merge (squash) December 18, 2024 13:24
@eps1lon eps1lon force-pushed the update/react/372ec00c-20241209 branch from 014fd6c to a192886 Compare December 18, 2024 13:26
@eps1lon eps1lon merged commit 5870091 into canary Dec 18, 2024
124 of 129 checks passed
@eps1lon eps1lon deleted the update/react/372ec00c-20241209 branch December 18, 2024 13:50
@github-actions github-actions bot added the locked label Jan 2, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eps1lon eps1lon eps1lon approved these changes

Assignees

@eps1lon eps1lon

Labels

CI approved Approve running CI for fork locked type: next type: react-sync

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vercel-release-bot @ijjk @eps1lon