-
Notifications
You must be signed in to change notification settings - Fork 29.7k
chore: add light/dark mode theme detection to image component example #53760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kodiakhq
merged 9 commits into
canary
from
styfle/next-1501-docs-for-dark-mode-theme-switching-for-nextimage
Aug 9, 2023
Merged
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a8b0310
chore: add light/dark mode theme detection to image component example
styfle 1fc94ff
update docs
styfle 4f97afa
vs => and
styfle f5753e5
Merge branch 'canary' into styfle/next-1501-docs-for-dark-mode-theme-…
styfle 09377db
Apply suggestions from code review
styfle 9709feb
add typescript snippet too
styfle 6f9e041
Apply suggestions from code review
styfle 2480723
Mention fetchPriority=high
styfle d654afc
Merge branch 'canary' into styfle/next-1501-docs-for-dark-mode-theme-…
leerob File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| import Image, { ImageProps } from 'next/image' | ||
| import ViewSource from '../components/view-source' | ||
| import styles from '../styles.module.css' | ||
|
|
||
| // Note: we cannot use `priority` or `loading="eager" | ||
| // because we depend on the default `loading="lazy"` | ||
| // behavior to wait for CSS to reveal the proper image. | ||
| type Props = Omit<ImageProps, 'src' | 'priority' | 'loading'> & { | ||
| srcLight: string | ||
| srcDark: string | ||
| } | ||
|
|
||
| const ThemeImage = (props: Props) => { | ||
| const { srcLight, srcDark, ...rest } = props | ||
|
|
||
| return ( | ||
| <> | ||
| <Image {...rest} src={srcLight} className={styles.imgLight} /> | ||
| <Image {...rest} src={srcDark} className={styles.imgDark} /> | ||
| </> | ||
| ) | ||
| } | ||
|
|
||
| const Page = () => ( | ||
| <div> | ||
| <ViewSource pathname="pages/theme.tsx" /> | ||
| <h1>Image With Light/Dark Theme Detection</h1> | ||
| <ThemeImage | ||
| alt="Next.js Streaming" | ||
| srcLight="https://assets.vercel.com/image/upload/front/nextjs/streaming-light.png" | ||
| srcDark="https://assets.vercel.com/image/upload/front/nextjs/streaming-dark.png" | ||
| width={588} | ||
| height={387} | ||
| /> | ||
| </div> | ||
| ) | ||
|
|
||
| export default Page |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.