fix(metrics): prevent negative utilization on late messages #24073
+51
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents late messages from breaking expected utilization bounds, by clamping all late messages to the start of reporting period. Messages arrive in order, so that should not break the expected state (waiting or not waiting). Utilization metric can still be slightly inaccurate on late messages, but it was never meant to be completely accurate. Fixes: vectordotdev#24060
esensar
commented
Oct 25, 2025
Comment on lines
+129
to
+130
| let now = Instant::now(); | ||
| self.end_span(now); |
There was a problem hiding this comment.
I assume I left these return values for start_wait, end_wait and end_span from some previous iteration of this. I removed them now for some clarity.
esensar
commented
Oct 25, 2025
Comment on lines
+159
to
+161
| // At can be before span start here, the result will be clamped to 0 | ||
| // because `duration_since` returns zero if at is before span start | ||
| self.total_wait += at.duration_since(self.span_start); |
There was a problem hiding this comment.
This is the same as using Sub, but I thought this might be more clear about the clamping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This prevents late messages from breaking expected utilization bounds, by clamping all late messages to the start of reporting period. Messages arrive in order, so that should not break the expected state (waiting or not waiting). Utilization metric can still be slightly inaccurate on late messages, but it was never meant to be completely accurate.
How did you test this PR?
Tested with the included unit tests.
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details here.