-
Notifications
You must be signed in to change notification settings - Fork 1.9k
chore(vdev): add vdev release command #24061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
7db98c1 to
f4bd968
Compare
| info!("Pushing to origin"); | ||
| git::push_branch(MAIN_BRANCH)?; | ||
| debug!("Pushed to {MAIN_BRANCH} branch."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this push a commit directly to master? I don't think this is a good idea and I also don't think it will work since we have branch protection rules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the simplest way. Only repo maintainers will ever use this script and they can push to master. I considered bumping locally, publishing, and making a workflow commit the new version. But I don't see why the latter is better really.
Alternative is to make a PR, update the version and then run this script to update the tag. You can think about it a bit more if you want.
Summary
Vector configuration
How did you test this PR?
Will try to release after this is merged.
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details here.