Skip to content

Conversation

@pront
Copy link
Member

@pront pront commented Oct 23, 2025

Summary

Vector configuration

How did you test this PR?

Will try to release after this is merged.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • make fmt
      • make check-clippy (if there are failures it's possible some of them can be fixed with make clippy-fix)
      • make test
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run make build-licenses to regenerate the license inventory and commit the changes (if any). More details here.

@github-actions github-actions bot added the domain: vdev Anything related to the vdev tooling label Oct 23, 2025
@pront pront force-pushed the pront-release-vdev branch from 7db98c1 to f4bd968 Compare October 23, 2025 14:05
@github-actions github-actions bot added the domain: ci Anything related to Vector's CI environment label Oct 23, 2025
@github-actions github-actions bot removed the domain: ci Anything related to Vector's CI environment label Oct 23, 2025
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Oct 23, 2025
@pront pront marked this pull request as ready for review October 23, 2025 14:56
@pront pront requested a review from a team as a code owner October 23, 2025 14:56
Comment on lines +93 to +95
info!("Pushing to origin");
git::push_branch(MAIN_BRANCH)?;
debug!("Pushed to {MAIN_BRANCH} branch.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this push a commit directly to master? I don't think this is a good idea and I also don't think it will work since we have branch protection rules

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the simplest way. Only repo maintainers will ever use this script and they can push to master. I considered bumping locally, publishing, and making a workflow commit the new version. But I don't see why the latter is better really.

Alternative is to make a PR, update the version and then run this script to update the tag. You can think about it a bit more if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: vdev Anything related to the vdev tooling no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants