Skip to content

Conversation

@powerumc
Copy link
Contributor

@powerumc powerumc commented Oct 22, 2025

Summary

This PR implemented a new ODBC(Open Database Connectivity) Source.

Vector configuration

[sources.odbc]
type = "odbc"
connection_string = ""
#connection_string_filepath = None
#schedule = None
schedule_timezone = "UTC"
#statement = None
statement_timeout = 3
#statement_init_params = None
#statement_filepath = None
odbc_batch_size = 100
odbc_max_str_limit = 4096
odbc_default_timezone = "UTC"
#tracking_columns = None
#last_run_metadata_path = None

How did you test this PR?

I tested it with integration tests of two databases: MariaDB and Postgresql.
(Testing the MySQL container integration in an ARM64 architecture is not simple, so I tested it with MariaDB. Instead, I manually tested MySQL locally.)

cargo vdev integration test odbc-mariadb
cargo vdev integration test odbc-postgresql

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • make fmt
      • make check-clippy (if there are failures it's possible some of them can be fixed with make clippy-fix)
      • make test
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run make build-licenses to regenerate the license inventory and commit the changes (if any). More details here.

powerumc added 29 commits July 24, 2025 20:53
# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	scripts/integration/Dockerfile
#	src/internal_events/mod.rs
#	src/sources/mod.rs
@github-actions github-actions bot added the domain: sources Anything related to the Vector's sources label Oct 22, 2025
@github-actions github-actions bot added the domain: external docs Anything related to Vector's external, public documentation label Oct 22, 2025
@powerumc powerumc marked this pull request as ready for review October 22, 2025 13:15
@powerumc powerumc requested review from a team as code owners October 22, 2025 13:15
@urseberry urseberry self-assigned this Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: external docs Anything related to Vector's external, public documentation domain: sources Anything related to the Vector's sources

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants