feat(opentelemetry sink): Partitioning/batching based on instrumentation scope #24025
+547
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
domain: sinks
pront
changed the title
|
Hi @Sambhram1, thank you for this PR! Please add a changelog and more importantly please fill in the review PR (summary, config, test plan) to enable me to review this easier. Thanks again. |
pront
reviewed
Oct 21, 2025
There was a problem hiding this comment.
Thanks @Sambhram1. Left a couple of UX related comments.
Also, did you test this end to end?
|
no i have not tested it end to end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements improved batching and performance for the opentelemetry sink by introducing a new instrumentation_scope partitioning strategy. This addresses the issue where the current implementation uses URI and headers as partition keys, resulting in poor batching efficiency for OTLP data.
Relates: #23848