Skip to content

feat(new source): okta #22968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Aug 29, 2025
Merged

feat(new source): okta #22968

merged 33 commits into from
Aug 29, 2025

Conversation

@sonnens
Copy link
Contributor

@sonnens sonnens commented Apr 30, 2025 •
edited by thomasqueirozb
Loading

Summary

Adds a new source to consume the Okta system log / audit log

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Tests are included in the PR, and I've run it on our own Okta instance

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

References

@sonnens sonnens requested a review from a team as a code owner April 30, 2025 15:55
@github-actions github-actions bot added the domain: sources Anything related to the Vector's sources label Apr 30, 2025
@pront pront self-assigned this Apr 30, 2025
@sonnens
Copy link
Contributor Author

sonnens commented May 19, 2025

@pront anything needed on my end for this one?

@pront
Copy link
Member

pront commented May 19, 2025

@pront anything needed on my end for this one?

Hi @sonnens, and thank you for this PR! We want a few more docs files. You can look at other PRs for inspiration: https://github.com/vectordotdev/vector/pull/22609/files.

Note that make generate-component-docs will generate the files under base/ but the other CUE file needs to be handwritten.

@sonnens sonnens requested a review from a team as a code owner May 19, 2025 20:23
@github-actions github-actions bot added the domain: external docs Anything related to Vector's external, public documentation label May 19, 2025
@sonnens
Copy link
Contributor Author

sonnens commented May 19, 2025

@pront something like this work?

hestonhoffman
hestonhoffman approved these changes May 19, 2025
View reviewed changes
Copy link
Contributor

@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 I left a couple small docs suggestions

@sonnens
Copy link
Contributor Author

sonnens commented Jun 16, 2025

@pront any updates?

@pront
Copy link
Member

pront commented Jun 17, 2025

@pront any updates?

Hi @sonnens, I was away for a few weeks. We will take a look soon.

@pront pront requested a review from thomasqueirozb June 17, 2025 15:02
pront
pront reviewed Jun 27, 2025
View reviewed changes
@pront pront added the meta: awaiting author Pull requests that are awaiting their author. label Jun 27, 2025
@github-actions github-actions bot removed the meta: awaiting author Pull requests that are awaiting their author. label Jun 30, 2025
@sonnens
Copy link
Contributor Author

sonnens commented Jun 30, 2025

@pront moved around the lock guard & cleaned up the error handling (I was cribbing off other sources 🤷‍♀️)

@sonnens sonnens requested a review from pront June 30, 2025 23:46
pront
pront approved these changes Jul 1, 2025
View reviewed changes
Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks mostly good!

Did you have a chance to test this E2E after the lock changes?

pront
pront approved these changes Jul 1, 2025
View reviewed changes
Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks mostly good!

Did you have a chance to test this E2E after the lock changes?

@thomasqueirozb thomasqueirozb added the meta: awaiting author Pull requests that are awaiting their author. label Jul 7, 2025
@thomasqueirozb thomasqueirozb added the source: new A request for a new source label Aug 20, 2025
thomasqueirozb
thomasqueirozb requested changes Aug 20, 2025
View reviewed changes
Copy link
Contributor

@thomasqueirozb thomasqueirozb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing. I checked out to commit ed601dc (which was the last commit you authored) and tests are still failing on that commit.

@thomasqueirozb thomasqueirozb added the meta: awaiting author Pull requests that are awaiting their author. label Aug 20, 2025
@github-actions github-actions bot removed the meta: awaiting author Pull requests that are awaiting their author. label Aug 26, 2025
@sonnens sonnens requested a review from thomasqueirozb August 26, 2025 20:07
@sonnens
Copy link
Contributor Author

sonnens commented Aug 26, 2025

@thomasqueirozb I'm not sure why check-docs is failing in CI , but I fixed the tests

thomasqueirozb
thomasqueirozb approved these changes Aug 29, 2025
View reviewed changes
Copy link
Contributor

@thomasqueirozb thomasqueirozb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, thanks!

@thomasqueirozb thomasqueirozb added this pull request to the merge queue Aug 29, 2025
Merged via the queue into vectordotdev:master with commit 56eee56 Aug 29, 2025
69 checks passed
@sonnens sonnens deleted the source_okta branch October 24, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pront pront pront approved these changes

@hestonhoffman hestonhoffman hestonhoffman approved these changes

@thomasqueirozb thomasqueirozb thomasqueirozb approved these changes

Assignees

@pront pront

Labels

domain: external docs Anything related to Vector's external, public documentation domain: sources Anything related to the Vector's sources source: new A request for a new source source: okta

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Okta system log source

4 participants

@sonnens @pront @hestonhoffman @thomasqueirozb