Skip to content

Conversation

@jszwedko
Copy link
Member

@jszwedko jszwedko commented Feb 9, 2022

Reverts #11222

This introduced a backwards incompatible change to VRL that broke the http_pipelines_blackhole soak tests. See https://github.com/vectordotdev/vector/runs/5126198293?check_suite_focus=true

The failure is:

error[E103]: unhandled fallible assignment
   ┌─ :19:13
   │
19 │     .tags = push(.tags, tag)
   │     ------- ^^^^^^^^^^^^^^^^
   │     │       │
   │     │       this expression is fallible
   │     │       update the expression to be infallible
   │     or change this to an infallible assignment:
   │     .tags, err = push(.tags, tag)
   │
   = see documentation about error handling at https://errors.vrl.dev/#handling
   = learn more about error code 103 at https://errors.vrl.dev/103
   = see language documentation at https://vrl.dev/

It's unclear from the PR if this was intended or not. If it was intended, we should update add an upgrade hightlight given it is a break in compatibility and update the soak test.

@netlify
Copy link

netlify bot commented Feb 9, 2022

✔️ Deploy Preview for vector-project ready!

🔨 Explore the source changes: 63e8ab8

🔍 Inspect the deploy log: https://app.netlify.com/sites/vector-project/deploys/6204487c3447550007d536d8

😎 Browse the preview: https://deploy-preview-11287--vector-project.netlify.app

@jszwedko jszwedko changed the title revert(vrl): use new value crate for type checking in VRL chore(vrl): Revert use new value crate for type checking in VRL Feb 9, 2022
@github-actions github-actions bot added domain: external docs Anything related to Vector's external, public documentation domain: transforms Anything related to Vector's transform components domain: vrl Anything related to the Vector Remap Language labels Feb 9, 2022
@jszwedko jszwedko merged commit a7aadee into master Feb 10, 2022
@jszwedko jszwedko deleted the revert-11222-jean/vrl-value-lib branch February 10, 2022 00:01
JeanMertz added a commit that referenced this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: external docs Anything related to Vector's external, public documentation domain: transforms Anything related to Vector's transform components domain: vrl Anything related to the Vector Remap Language

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants