chore(vrl): Reduce VRL core such that it doesn't have any other dependencies to VRL #10767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for vector-project canceled. 🔨 Explore the source changes: 28cc0d5 🔍 Inspect the deploy log: https://app.netlify.com/sites/vector-project/deploys/61dd61a88c6aa000085e76a9 |
github-actions
bot
added
domain: core
pablosichert
force-pushed
the
pablosichert/vrl-core-refactor
branch
3 times, most recently
from
d5032f4 to
637c93a
Compare
Signed-off-by: Pablo Sichert <[email protected]>
Signed-off-by: Pablo Sichert <[email protected]>
pablosichert
force-pushed
the
pablosichert/vrl-core-refactor
branch
from
637c93a to
9d9b2cf
Compare
pablosichert
commented
Jan 10, 2022
Comment on lines
-9
to
-11
| compiler = { package = "vrl-compiler", path = "../compiler" } | ||
| diagnostic = { package = "vrl-diagnostic", path = "../diagnostic" } | ||
| parser = { package = "vrl-parser", path = "../parser" } |
There was a problem hiding this comment.
Tl;dr: All the other changes are a consequence of this 😄
There was a problem hiding this comment.
that's a lotta changes
Signed-off-by: Pablo Sichert <[email protected]>
blt
approved these changes
Jan 10, 2022
|
Always wanted to see this get done. Nice, @pablosichert. |
Soak Test ResultsBaseline: 340f939 ExplanationA soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Test units below are bytes/second/CPU, except for "skewness". The further "skewness" is from 0.0 the more indication that vector lacks consistency in behavior, making predictions of fitness in the field challenging. The abbreviated table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. The abbreviated table will be omitted if no statistically interesting changes are observed.
Fine details of change detection per experiment.
Fine details of each soak run.
|
|
Soaks seem to be a bit flakey. Effectively there is no change in this PR. |
Soak Test ResultsBaseline: ed7fcc6 ExplanationA soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Test units below are bytes/second/CPU, except for "skewness". The further "skewness" is from 0.0 the more indication that vector lacks consistency in behavior, making predictions of fitness in the field challenging. The abbreviated table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. The abbreviated table will be omitted if no statistically interesting changes are observed. No statistically interesting changes with confidence 90.00%. Fine details of change detection per experiment.
Fine details of each soak run.
|
Soak Test ResultsBaseline: 7301856 ExplanationA soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Test units below are bytes/second/CPU, except for "skewness". The further "skewness" is from 0.0 the more indication that vector lacks consistency in behavior, making predictions of fitness in the field challenging. The abbreviated table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. The abbreviated table will be omitted if no statistically interesting changes are observed. No statistically interesting changes with confidence 90.00%. Fine details of change detection per experiment.
Fine details of each soak run.
|
| @@ -1,4 +1,4 @@ | |||
| use vrl::prelude::*; | |||
| use crate::prelude::*; | |||
There was a problem hiding this comment.
How has this change been made possible? I'm not seeing anywhere where prelude has been pulled into the stdlib crate..
There was a problem hiding this comment.
Moved it to stdlib/src/lib.rs:
vector/lib/vrl/stdlib/src/lib.rs
Lines 747 to 760 in 28cc0d5
There was a problem hiding this comment.
I'm not so sure I'm keen on this since enrichment tables and other libs that implement VRL functions no longer have access to it. Would it not be better to move this to vrl_core or similar?
There was a problem hiding this comment.
As discussed offline with @JeanMertz, we'll introduce a new vrl crate that includes vrl_core and all the other vrl related crates.
However, I'm not sure we can share this particular piece, since that would mean having a cyclic dependency on vrl -> stdlib -> vrl. We can add an equivalent prelude to vrl to be accessible from the outside, though.
JeanMertz
suggested changes
Jan 11, 2022
|
Closing this since we landed a couple of big refactorings on master in the mean time that relate to/conflict with this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10764.