-
Notifications
You must be signed in to change notification settings - Fork 8.3k
fix: 1、更换其他登录方式图标为彩色图标;2、新增其他登录方式tooltip文字提示 #6799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
WalkthroughIcon components were migrated from Mdi* to Svg* across multiple UI files. Corresponding exports were removed from iconify and added under svg. Authentication locale entries were extended in en-US and zh-CN. No logic, control flow, or data handling changes were introduced. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/locales/src/langs/en-US/authentication.json (1)
54-57: Consider using consistent key naming convention.The new locale keys use mixed capitalization (weChat, gitHub) which is inconsistent with existing similar keys that use all lowercase (wechatLogin, qqLogin, githubLogin at lines 39-43). Consider using lowercase for consistency:
Apply this diff to align with the existing naming convention:
- "weChat": "WeChat", - "qq": "QQ", - "gitHub": "GitHub", - "google": "Google", + "wechat": "WeChat", + "qq": "QQ", + "github": "GitHub", + "google": "Google",Note: If you apply this change, ensure that all references to these keys in the codebase (e.g., in Vue components) are also updated accordingly.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (5)
packages/icons/src/svg/icons/dingding.svgis excluded by!**/*.svgpackages/icons/src/svg/icons/github.svgis excluded by!**/*.svgpackages/icons/src/svg/icons/google.svgis excluded by!**/*.svgpackages/icons/src/svg/icons/qqchat.svgis excluded by!**/*.svgpackages/icons/src/svg/icons/wechat.svgis excluded by!**/*.svg
📒 Files selected for processing (11)
apps/web-antd/src/layouts/basic.vue(2 hunks)apps/web-ele/src/layouts/basic.vue(2 hunks)apps/web-naive/src/layouts/basic.vue(2 hunks)packages/effects/common-ui/src/ui/authentication/dingding-login.vue(2 hunks)packages/effects/common-ui/src/ui/authentication/third-party-login.vue(2 hunks)packages/icons/src/iconify/index.ts(0 hunks)packages/icons/src/svg/index.ts(2 hunks)packages/locales/src/langs/en-US/authentication.json(1 hunks)packages/locales/src/langs/zh-CN/authentication.json(1 hunks)playground/src/layouts/basic.vue(2 hunks)playground/src/views/demos/features/icons/index.vue(2 hunks)
💤 Files with no reviewable changes (1)
- packages/icons/src/iconify/index.ts
🧰 Additional context used
🧬 Code graph analysis (1)
packages/icons/src/svg/index.ts (1)
packages/@core/base/icons/src/create-icon.ts (1)
createIconifyIcon(14-14)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: Check (windows-latest)
- GitHub Check: Test (ubuntu-latest)
- GitHub Check: Lint (ubuntu-latest)
- GitHub Check: Check (ubuntu-latest)
- GitHub Check: Lint (windows-latest)
- GitHub Check: Test (windows-latest)
- GitHub Check: post-update (ubuntu-latest)
- GitHub Check: post-update (windows-latest)
🔇 Additional comments (13)
packages/icons/src/svg/index.ts (2)
14-18: LGTM! Icon definitions follow the established pattern.The new SVG icon constants are correctly defined using
createIconifyIconand follow the same pattern as existing icons.
29-34: LGTM! Exports are properly ordered.The new icon exports are alphabetically ordered and follow the existing export conventions.
apps/web-antd/src/layouts/basic.vue (2)
9-9: LGTM! Icon import correctly updated.The import has been properly updated from the old Mdi icon to the new SVG icon variant.
79-79: LGTM! Icon usage matches the import.The icon component usage is consistent with the updated import.
apps/web-ele/src/layouts/basic.vue (1)
9-9: LGTM! Consistent icon replacement.The GitHub icon has been correctly replaced with the SVG variant, matching the pattern used in other layout files.
Also applies to: 79-79
playground/src/layouts/basic.vue (1)
9-9: LGTM! Icon replacement matches other layouts.The icon update is consistent with the changes made to other layout files (web-antd, web-ele, web-naive).
Also applies to: 92-92
packages/effects/common-ui/src/ui/authentication/dingding-login.vue (1)
4-4: LGTM! DingDing icon successfully migrated to SVG.The icon replacement from
RiDingdingtoSvgDingDingIconis correct and follows the pattern used throughout this PR.Also applies to: 99-99
apps/web-naive/src/layouts/basic.vue (1)
9-9: LGTM! All layout variants now use consistent SVG icons.The icon update completes the migration across all layout variants (web-antd, web-ele, web-naive, playground).
Also applies to: 79-79
packages/effects/common-ui/src/ui/authentication/third-party-login.vue (2)
3-8: LGTM! Icon imports correctly updated.All four third-party login icons have been properly migrated from Mdi* to Svg* variants:
- MdiWechat → SvgWeChatIcon
- MdiQqchat → SvgQQChatIcon
- MdiGithub → SvgGithubIcon
- MdiGoogle → SvgGoogleIcon
40-61: LGTM! Icon usages match the updated imports.All icon component usages have been correctly updated to use the new SVG icon components. The tooltips (
wechatLogin,qqLogin,githubLogin,googleLogin) were already present prior to this PR.packages/locales/src/langs/zh-CN/authentication.json (1)
54-57: Confirm new localization keys are usedNo occurrences of
authentication.weChat,authentication.qq,authentication.gitHub, orauthentication.googlewere found. Verify whether these are intended for future use or should be removed to prevent dead code.packages/locales/src/langs/en-US/authentication.json (1)
54-57: No discrepancies found in zh-CN authentication.json zh-CN locale keys match en-US exactly.playground/src/views/demos/features/icons/index.vue (1)
15-18: All authentication components use new Svg icons* Authentication components (including third-party-login.vue) now import and render SvgGithubIcon, SvgGoogleIcon, SvgQQChatIcon, and SvgWeChatIcon with no remaining Mdi* icon usage.
Description
Type of change
Please delete options that are not relevant.
pnpm-lock.yamlunless you introduce a new test example.Checklist
pnpm run docs:devcommand.pnpm test.feat:,fix:,perf:,docs:, orchore:.Summary by CodeRabbit
Style
New Features