Skip to content

Conversation

@kjaymiller
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Resolves #31 by removing the changes update request in the PR template and adding a comment to the top of the CHANGES file.

This is a cleaned up version of #33

@kjaymiller
Copy link
Contributor Author

@ahmedsobeh - it was easier to submit a new PR from a different branch.

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@01db8ba). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage        ?   75.02%           
=======================================
  Files           ?      132           
  Lines           ?    34350           
  Branches        ?        0           
=======================================
  Hits            ?    25772           
  Misses          ?     8578           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@aiven-sal aiven-sal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aiven-sal aiven-sal self-requested a review July 5, 2024 16:10
@ahmedsobeh
Copy link
Collaborator

LGTM! Thanks for submitting it again

@ahmedsobeh ahmedsobeh merged commit 5a7e4ca into valkey-io:main Jul 6, 2024
Copy link

@aaron-muti-420 aaron-muti-420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm New here.., How do I Perform a Review on this PR?

@mkmkme
Copy link
Collaborator

mkmkme commented Jul 8, 2024

@aaron-muti-420 you can click on a line you want to add a comment to in the tab called "Files changes". While writing a comment, there will be either "Start a review" and "Add a single comment" buttons. Use whatever feels more natural.

@kjaymiller kjaymiller deleted the jm-patches-33 branch July 8, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update PR Template to no longer request updating the Changes File/Potentially Remove the CHANGES file

6 participants