-
Notifications
You must be signed in to change notification settings - Fork 31
Spelling #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spelling #204
Conversation
mkmkme
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey,
Thanks for your PR! The changes look good, but I have some nits that I want you to address.
In general, I have two things that I want to be changed in the PR:
- Drop
X, otherwise Y->X; otherwise, Ychange. It makes the text less readable for me personally, I don't like it. - Please squash your commits. 69 commits for just spell checking in the code is way too much.
In addition to that, I left some inline comments.
|
Sorry for the delay, I'll have a look at it on the upcoming two days |
|
Thanks, the changes look good! I'll introduce the new merge strategy to this repo and will merge it today. Sorry for the delay! |
|
The CI failure is unrelated to the changes and is likely related to new |
|
@ahmedsobeh no worries, I'll fix the PR within an hour :) |
|
Huh actually it is related to the changes in the PR. Nevermind, I'll fix them nonetheless |
|
Apparently I can't push to your PR. @jsoref could you please fix the formatting issue and push it to the PR? |
|
@mkmkme that's odd, GitHub says maintainers should be able to: I can try shortly |
|
@jsoref oh wait, I figured it out, you're right. I'll fix this |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #204 +/- ##
=======================================
Coverage 76.27% 76.27%
=======================================
Files 130 130
Lines 33985 33985
=======================================
Hits 25921 25921
Misses 8064 8064 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Josh Soref <[email protected]>

Pull Request check-list
Description of change
This PR corrects misspellings identified by the check-spelling action
The misspellings have been reported at https://github.com/jsoref/valkey-py/actions/runs/15615962349/attempts/1#summary-43988709855
The action reports that the changes in this PR would make it happy: https://github.com/jsoref/valkey-py/actions/runs/15615962850/attempts/1#summary-43988712051