Skip to content

Conversation

@jsoref
Copy link
Contributor

@jsoref jsoref commented Jun 12, 2025

Pull Request check-list

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

Description of change

This PR corrects misspellings identified by the check-spelling action

The misspellings have been reported at https://github.com/jsoref/valkey-py/actions/runs/15615962349/attempts/1#summary-43988709855

The action reports that the changes in this PR would make it happy: https://github.com/jsoref/valkey-py/actions/runs/15615962850/attempts/1#summary-43988712051

@jsoref jsoref marked this pull request as ready for review June 12, 2025 16:47
Copy link
Collaborator

@mkmkme mkmkme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,

Thanks for your PR! The changes look good, but I have some nits that I want you to address.

In general, I have two things that I want to be changed in the PR:

  1. Drop X, otherwise Y -> X; otherwise, Y change. It makes the text less readable for me personally, I don't like it.
  2. Please squash your commits. 69 commits for just spell checking in the code is way too much.

In addition to that, I left some inline comments.

@mkmkme
Copy link
Collaborator

mkmkme commented Jun 16, 2025

Sorry for the delay, I'll have a look at it on the upcoming two days

@mkmkme
Copy link
Collaborator

mkmkme commented Jul 2, 2025

Thanks, the changes look good! I'll introduce the new merge strategy to this repo and will merge it today. Sorry for the delay!

@mkmkme
Copy link
Collaborator

mkmkme commented Jul 2, 2025

The CI failure is unrelated to the changes and is likely related to new black version. I'll fix it in main and will update the branch

@mkmkme
Copy link
Collaborator

mkmkme commented Jul 2, 2025

@ahmedsobeh no worries, I'll fix the PR within an hour :)

@mkmkme
Copy link
Collaborator

mkmkme commented Jul 2, 2025

Huh actually it is related to the changes in the PR. Nevermind, I'll fix them nonetheless

@mkmkme
Copy link
Collaborator

mkmkme commented Jul 2, 2025

Apparently I can't push to your PR. @jsoref could you please fix the formatting issue and push it to the PR?

@jsoref
Copy link
Contributor Author

jsoref commented Jul 2, 2025

@mkmkme that's odd, GitHub says maintainers should be able to:
Screenshot_20250702-075915

I can try shortly

@mkmkme
Copy link
Collaborator

mkmkme commented Jul 2, 2025

@jsoref oh wait, I figured it out, you're right. I'll fix this

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2025

Codecov Report

Attention: Patch coverage is 70.96774% with 9 lines in your changes missing coverage. Please review.

Project coverage is 76.27%. Comparing base (d9ff3ff) to head (8b16940).

Files with missing lines Patch % Lines
valkey/commands/search/querystring.py 0.00% 2 Missing ⚠️
tests/conftest.py 0.00% 1 Missing ⚠️
tests/test_cluster.py 88.88% 1 Missing ⚠️
tests/test_ssl.py 66.66% 1 Missing ⚠️
valkey/commands/core.py 50.00% 1 Missing ⚠️
valkey/commands/graph/__init__.py 50.00% 1 Missing ⚠️
valkey/commands/graph/execution_plan.py 0.00% 1 Missing ⚠️
valkey/ocsp.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #204   +/-   ##
=======================================
  Coverage   76.27%   76.27%           
=======================================
  Files         130      130           
  Lines       33985    33985           
=======================================
  Hits        25921    25921           
  Misses       8064     8064           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Josh Soref <[email protected]>
@mkmkme mkmkme enabled auto-merge July 2, 2025 12:16
@mkmkme mkmkme disabled auto-merge July 2, 2025 12:16
@mkmkme mkmkme enabled auto-merge July 2, 2025 12:16
@mkmkme mkmkme merged commit 753cd5a into valkey-io:main Jul 2, 2025
85 checks passed
@jsoref jsoref deleted the spelling branch July 2, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants