Skip to content

Conversation

@aiven-sal
Copy link
Member

@aiven-sal aiven-sal commented May 23, 2024

I'm pretty sure I overlooked something.
But all tests pass locally.
I don't expect the CI to work 100% yet, but we should fix it before we merge.

@mkmkme mkmkme self-assigned this May 23, 2024
Copy link
Collaborator

@mkmkme mkmkme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the pull request, Salvatore! Great job!

I've left some of the nitpicks I managed to get during the review. I believe, though, that the only types that actually have to be changed before merge are:

  1. Automatic changes in words "storedist" and "redistribution"
  2. Links to the old issues
  3. An unchanged link to redis.io

Everything else (including multiple references to the "old valkey version" and "old valkey-py version") can be addressed later.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@aiven-sal
Copy link
Member Author

Most issues should be fixed. If I put a 👍 under your comment, please check if the solution is satisfying and resolve the conversation or comment again.
If I didn't put any 👍 under your comment, I'm saving it for later.
Thanks :)

@aiven-sal aiven-sal requested review from jfg956 and mkmkme May 24, 2024 13:09
Copy link
Collaborator

@mkmkme mkmkme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the comments have been fixed, but I still found a couple of places that should be changed before we merge this one

@aiven-sal aiven-sal requested a review from mkmkme May 27, 2024 08:09
Copy link
Collaborator

@mkmkme mkmkme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks again for the great job!

@aiven-sal aiven-sal merged commit ce9b87a into main May 27, 2024
@aiven-sal aiven-sal deleted the valkeyfork branch May 27, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants