Skip to content

Conversation

@mkmkme
Copy link
Collaborator

@mkmkme mkmkme commented May 5, 2025

Some of MONITOR tests got broken due to a bug in the server: valkey-io/valkey#2036

This commit disables those tests for these versions of Valkey server thus letting the CI proceed.

Pull Request check-list

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

Description of change

@codecov-commenter
Copy link

codecov-commenter commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.17%. Comparing base (994ed74) to head (be835c3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
- Coverage   76.25%   76.17%   -0.09%     
==========================================
  Files         130      130              
  Lines       33970    33980      +10     
==========================================
- Hits        25904    25883      -21     
- Misses       8066     8097      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Some of MONITOR tests got broken due to a bug in the server:
valkey-io/valkey#2036

This commit disables those tests for these versions of Valkey server
thus letting the CI proceed.

Signed-off-by: Mikhail Koviazin <[email protected]>
@mkmkme mkmkme force-pushed the mkmkme/fix-monitor-tests branch from 0c3027a to f2a4b5b Compare May 5, 2025 10:52
@mkmkme mkmkme changed the title tests: disable some monitor tests for 8.1.0 and 8.1.1 Drop support for Python 3.8 and disable tests broken in 8.1.0..8.1.1 May 5, 2025
Signed-off-by: Mikhail Koviazin <[email protected]>
@mkmkme mkmkme force-pushed the mkmkme/fix-monitor-tests branch from f2a4b5b to be835c3 Compare May 5, 2025 11:03
@mkmkme mkmkme enabled auto-merge May 5, 2025 16:20
Copy link
Collaborator

@bogdanp05 bogdanp05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mkmkme mkmkme merged commit f6065c8 into main May 5, 2025
85 checks passed
@mkmkme mkmkme deleted the mkmkme/fix-monitor-tests branch May 5, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants