Skip to content

Conversation

@SaidBySolo
Copy link
Contributor

@SaidBySolo SaidBySolo commented Mar 28, 2025

Pull Request check-list

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

Description of change

It complains that the type of kwargs is Unknown.

I added it explicitly as Any for now.

Signed-off-by: Ryu Juheon <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.25%. Comparing base (ca5c7c5) to head (8d28f88).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
- Coverage   76.27%   76.25%   -0.02%     
==========================================
  Files         130      130              
  Lines       33970    33970              
==========================================
- Hits        25910    25904       -6     
- Misses       8060     8066       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@mkmkme mkmkme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks for your contribution! This is looking good to me, merging it now

@mkmkme mkmkme merged commit 994ed74 into valkey-io:main Mar 31, 2025
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants