Skip to content

Conversation

@jakob-keller
Copy link
Contributor

@jakob-keller jakob-keller commented Mar 25, 2025

Pull Request check-list

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

Description of change

The change prevents RuntimeError being raised when valkey.asyncio.cluster.NodeManager.startup_nodes are modified while performing .initialize().

Fixes #181

@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.17%. Comparing base (f6065c8) to head (77f3519).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #184   +/-   ##
=======================================
  Coverage   76.17%   76.17%           
=======================================
  Files         130      130           
  Lines       33980    33980           
=======================================
+ Hits        25883    25885    +2     
+ Misses       8097     8095    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mkmkme mkmkme self-assigned this Apr 2, 2025
Copy link
Collaborator

@ahmedsobeh ahmedsobeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR

@ahmedsobeh ahmedsobeh enabled auto-merge May 1, 2025 16:53
@mkmkme mkmkme disabled auto-merge May 5, 2025 07:38
@mkmkme
Copy link
Collaborator

mkmkme commented May 5, 2025

The CI failure seems unrelated. I'll fix it promptly and rebase the PR on the top of the current main

@mkmkme
Copy link
Collaborator

mkmkme commented May 5, 2025

The CI is broken due to the bug in valkey 8.1: valkey-io/valkey#2035

I'll restart the tests when the bug is fixed.

@mkmkme mkmkme merged commit 8f6d963 into valkey-io:main May 6, 2025
85 checks passed
@jakob-keller jakob-keller deleted the fix-runtime-error branch May 6, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RuntimeError in valkey.asyncio.cluster.NodesManager.initialize()

4 participants