fixed type hint of hrandfield method #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirreza8002
requested review from
ahmedsobeh,
aiven-sal,
bogdanp05,
mkmkme and
smeso
as code owners
aiven-sal
previously requested changes
Dec 16, 2024
Member
aiven-sal
left a comment
aiven-sal
left a comment
There was a problem hiding this comment.
Hi! 3.9 doesn't support this syntax. You should use Union.
Contributor
Author
|
ah |
amirreza8002
force-pushed
the
hrandtype
branch
from
869c834 to
1c87f81
Compare
amirreza8002
force-pushed
the
hrandtype
branch
from
1c87f81 to
1e3e881
Compare
mkmkme
previously approved these changes
Dec 16, 2024
amirreza8002
force-pushed
the
hrandtype
branch
from
1e3e881 to
b00b85c
Compare
Signed-off-by: amirreza <[email protected]>
amirreza8002
force-pushed
the
hrandtype
branch
from
b00b85c to
1fc6f9b
Compare
mkmkme
approved these changes
Dec 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
=======================================
Coverage 76.22% 76.22%
=======================================
Files 130 130
Lines 33946 33946
=======================================
Hits 25877 25877
Misses 8069 8069 ☔ View full report in Codecov by Sentry. |
mkmkme
dismissed
aiven-sal’s stale review
It was updated in the follow-up commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hrandfield returns a byte if no count is given
if count is given it returns a list of bytes
if there is no value found, it returns None