-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Refactor assertString: Faster, less nested and more consistent. #2372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+46
−9
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a8f5eb7
refactor: Refactor assertString
EmersonRabelo 241c4a8
refactor: Refactor assertString with unit tests
EmersonRabelo 69cb5fa
add: Empty string unit test
EmersonRabelo f726e2d
add: Null input value and more tests
EmersonRabelo f8e62de
fix: Sentence correction
EmersonRabelo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,4 @@ | ||
| export default function assertString(input) { | ||
| const isString = typeof input === 'string' || input instanceof String; | ||
|
|
||
| if (!isString) { | ||
| let invalidType = typeof input; | ||
| if (input === null) invalidType = 'null'; | ||
| else if (invalidType === 'object') invalidType = input.constructor.name; | ||
|
|
||
| throw new TypeError(`Expected a string but received a ${invalidType}`); | ||
| } | ||
| if (input === undefined) throw new TypeError(`Expected a string but received a ${input}`); | ||
| if (input.constructor.name !== 'String') throw new TypeError(`Expected a string but received a ${input.constructor.name}`); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.