Skip to content

Conversation

@ovarn
Copy link
Contributor

@ovarn ovarn commented Oct 14, 2023

The README.md file contained a few typos.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (c25b98f) to head (a730368).
Report is 11 commits behind head on master.

Current head a730368 differs from pull request most recent head b541a6e

Please upload reports for the commit b541a6e to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##            master    #2323      +/-   ##
===========================================
- Coverage   100.00%   99.95%   -0.05%     
===========================================
  Files          109      107       -2     
  Lines         2489     2449      -40     
  Branches       628      619       -9     
===========================================
- Hits          2489     2448      -41     
- Partials         0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

WikiRik
WikiRik previously approved these changes Oct 15, 2023
rubiin
rubiin previously approved these changes May 12, 2024
@rubiin rubiin added mc-to-land Just merge-conflict standing between the PR and landing. ✅ LGTM and removed ✅ LGTM labels Jun 1, 2024
@rubiin
Copy link
Member

rubiin commented Jun 1, 2024

@ovarn please fix the merge conflicts so we may merge this :)

@ovarn
Copy link
Contributor Author

ovarn commented Jun 2, 2024

I'll try to find the time today or tomorrow. Thanks!

@rubiin rubiin dismissed stale reviews from WikiRik and themself via 3896543 June 2, 2024 10:48
@rubiin
Copy link
Member

rubiin commented Jun 2, 2024

@ovarn no worries . I fixed them :)

@rubiin rubiin added 🧹 needs-update For PRs that need to be updated before landing and removed mc-to-land Just merge-conflict standing between the PR and landing. labels Jun 2, 2024
@rubiin rubiin requested review from WikiRik and rubiin June 2, 2024 10:58
Copy link
Member

@rubiin rubiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far

rubiin
rubiin previously requested changes Jun 2, 2024
Copy link
Member

@rubiin rubiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought, 'uk-UA' this seems to be deleted. Please check if that was a change you made

@rubiin rubiin self-requested a review June 2, 2024 11:05
@rubiin rubiin dismissed their stale review June 2, 2024 11:06

typo

@rubiin rubiin requested a review from profnandaa June 2, 2024 11:08
@ovarn
Copy link
Contributor Author

ovarn commented Jun 4, 2024

Looks like it was removed during the merge. When I did this PR, there was no 'uk-UA' in the isTaxID method. But I will fix it now.

@ovarn
Copy link
Contributor Author

ovarn commented Jun 4, 2024

@rubiin what would be the best approach to fix it? Should I revert the merge and do it again? Or should I just add the lang as an another commit?

@rubiin
Copy link
Member

rubiin commented Jun 5, 2024

since the changes are minor, the best approach is to stash your edits, pull the latest changes and add in your change. That we you wont get a merge conflict as you are working on latest changes

@ovarn
Copy link
Contributor Author

ovarn commented Jun 5, 2024

Thanks! It's done.

@rubiin rubiin removed the 🧹 needs-update For PRs that need to be updated before landing label Jun 6, 2024
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants