Fix command and argument escaping and path spaces

package.json

@@ -155,11 +155,9 @@
     "ts-watch": "tsc -watch -p ./"
   },
   "dependencies": {
-    "cross-spawn": "^7.0.3",
     "lodash": "^4.17.21"
   },
   "devDependencies": {
-    "@types/cross-spawn": "^6.0.6",
     "@types/lodash": "^4.14.202",
     "@types/mocha": "^10.0.6",
     "@types/node": "^20.11.20",

src/fixer.ts

@@ -1,5 +1,4 @@
-import spawn from 'cross-spawn';
-import { SpawnSyncOptions } from 'node:child_process';
+import { spawnSync, SpawnSyncOptions } from 'node:child_process';
 import {
   ConfigurationChangeEvent,
   Disposable,
@@ -74,9 +73,9 @@ const getArgs = (
    */
 
   if (standard !== '') {
-    args.push(`--standard=${standard}`);
+    args.push(`--standard="${standard}"`);
   }
-  args.push(`--stdin-path=${filePath}`);
+  args.push(`--stdin-path="${filePath}"`);
   args = args.concat(additionalArguments);
   args.push('-');
   return args;
@@ -154,13 +153,17 @@ const format = async (document: TextDocument, fullDocument: boolean) => {
     env: process.env,
     encoding: 'utf8',
     input: fileText,
+    // Required to prevent EINVAL errors when spawning .bat files on Windows.
+    // https://github.com/valeryan/vscode-phpsab/issues/128
+    // https://github.com/nodejs/node/issues/52554
+    shell: true,
   };
 
   logger.info(
     `FIXER COMMAND: ${resourceConf.executablePathCBF} ${lintArgs.join(' ')}`,
   );
 
-  const fixer = spawn.sync(resourceConf.executablePathCBF, lintArgs, options);
+  const fixer = spawnSync(resourceConf.executablePathCBF, lintArgs, options);
   const stdout = fixer.stdout.toString();
 
   let fixed = stdout;

src/sniffer.ts

@@ -1,17 +1,17 @@
 import { debounce } from 'lodash';
-import { spawn } from 'node:child_process';
+import { spawn, SpawnOptions } from 'node:child_process';
 import {
   CancellationTokenSource,
   ConfigurationChangeEvent,
   Diagnostic,
   DiagnosticCollection,
   DiagnosticSeverity,
   Disposable,
+  languages,
   Range,
   TextDocument,
   TextDocumentChangeEvent,
   Uri,
-  languages,
   window,
   workspace,
 } from 'vscode';
@@ -134,14 +134,17 @@
 
   let fileText = document.getText();
 
-  const options = {
+  const options: SpawnOptions = {
     cwd:
       resourceConf.workspaceRoot !== null
         ? resourceConf.workspaceRoot
         : undefined,
     env: process.env,
     encoding: 'utf8',
     tty: true,
+    // Required to prevent EINVAL errors when spawning .bat files on Windows.
+    // https://github.com/valeryan/vscode-phpsab/issues/128
+    // https://github.com/nodejs/node/issues/52554
     shell: true,
   };
   logger.info(
@@ -150,14 +153,14 @@
 
   const sniffer = spawn(resourceConf.executablePathCS, lintArgs, options);
 
   sniffer.stdin.write(fileText);
   sniffer.stdin.end();
 
   let stdout = '';
   let stderr = '';
 
   sniffer.stdout.on('data', (data) => (stdout += data));
   sniffer.stderr.on('data', (data) => (stderr += data));
 
   const done = new Promise<void>((resolve, reject) => {
     sniffer.on('close', () => {