-
Notifications
You must be signed in to change notification settings - Fork 87
Open
Labels
Description
Describe your motivation
Since #3192, the app-layout has the support of an i18n property for localization. The app-layout-drawer-toggle has an ariaLabel property that currently defaults to Toggle (proof). It was discussed internally that this property is a good candidate to be made configurable via the app-layout i18n property.
Presumably, it is not going to be a breaking change because the user anyway will be able to configure the aria-label attribute via both the i18n property and adding the attribute manually. What will change is that the default value for the attribute will come from the i18n property instead of the ariaLabel property.
Describe the solution you'd like
- Drop the
ariaLabelproperty for the drawer-toggle if it is not needed anymore. - Add a
drawerToggleproperty to thei18nproperty with the default valueToggle. - Set the
aria-labelattribute toi18n.drawerToggleat initialization if the user hasn't provided a custom one. - When the
i18nproperty changes, update thearia-labelattribute if the user hasn't provided a custom one.
knoobie