Add base and Aura component variants to *Variant classes.

[rolfsmeds]

Describe your motivation

What it says on the tin.

Describe the solution you'd like

Aura variants should of course be prefixed with AURA_, and I guess base variants can be unprefixed (i.e. just ButtonVariant.PRIMARY etc).

Describe alternatives you've considered

No response

Additional context

No response

[sissbruecker]

Is using ButtonVariant.PRIMARY valid for Aura (or Lumo) as well?

If I'm starting just starting out I might not know what "Aura" or "Lumo" are, so I would probably choose the most basic variant over the prefixed ones.

[rolfsmeds]

Good question. Since we already have LUMO_PRIMARY, we should keep that to avoid breaking every single Vaadin app.

For consistency, maybe we should have AURA_PRIMARY too?

Pinging @jouni for thoughts.

[jouni]

I would defer to people who are actually developing apps with Flow, I have so little practical experience with that nowadays that I’m not sure what difference it would make.

My understanding so far has been that we’d use the same constant if it’s referring to a base style variant, i.e., ButtonVariant.PRIMARY. Adding AURA_PRIMARY feels redundant to me.

Is this a bit similar as the distinction between --vaadin-*, --lumo-* and --aura-* properties?

[rolfsmeds]

I guess we could just introduce un-prefixed enums for base variants, at least for now, and see how people find that. And of course leave the LUMO_ equivalents as-is to avoid breaking everything. We can revisit the topic in conjunction with the refac-to-classnames and move-to-theme-classes discussion. Those can be introduced in minors, deprecating stuff that's no longer needed.

[knoobie]

see how people find that

people (me) like it 🤘