Skip to content

Add support for Campaigns for Apps #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 12, 2017
Merged

Add support for Campaigns for Apps #9

merged 4 commits into from
Dec 12, 2017

Conversation

@tzengerink
Copy link
Contributor

@tzengerink tzengerink commented Dec 5, 2017 •
edited by vox-eve
Loading

Thanks to @gvisniuc the Python client is close to supporting Campaigns for Apps 🎉

@Rifinio, @spirosikmd and @shuisman could you guys review the changes?

George Visniuc and others added 2 commits December 5, 2017 15:47
Added campaigns for apps support and examples
2ead8c8
Add Campaigns for Apps to the Readme
86802ff 
The Readme did not reference the Campaigns for Apps functionality yet.
Also the headers within the Readme were not rendered properly.
@coveralls
Copy link

coveralls commented Dec 5, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 78.182% when pulling 86802ff on campaign-for-apps into 8701fdc on master.

spirosikmd
spirosikmd approved these changes Dec 6, 2017
View reviewed changes
Copy link
Contributor

@spirosikmd spirosikmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Would be nice to set up tests!

Rifinio
Rifinio approved these changes Dec 6, 2017
View reviewed changes
Copy link

@Rifinio Rifinio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Add tests for the added resources
b2702c4 
Added a couple of tests to make sure the newly added resources are
considered valid. While doing so did a minor refactor.
@coveralls
Copy link

coveralls commented Dec 6, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.4%) to 78.571% when pulling b2702c4 on campaign-for-apps into 8701fdc on master.

Bump up the version
8cb05b9 
After adding support for Campaigns for Apps a new version has to be
tagged and published.
@coveralls
Copy link

coveralls commented Dec 6, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.4%) to 78.571% when pulling 8cb05b9 on campaign-for-apps into 8701fdc on master.

@tzengerink tzengerink merged commit dbb4929 into master Dec 12, 2017
@tzengerink tzengerink deleted the campaign-for-apps branch December 12, 2017 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shuisman shuisman Awaiting requested review from shuisman

2 more reviewers

@Rifinio Rifinio Rifinio approved these changes

@spirosikmd spirosikmd spirosikmd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tzengerink @coveralls @Rifinio @spirosikmd