Skip to content

Conversation

@hi-ogawa
Copy link
Collaborator

fontless doesn't rely on vite runtime, but it uses types to expose Plugin. Though this is a gray area, I think it should still have peer dependency since otherwise package manager is free to not make vite types visible from fontless.

I made it optional since fontless expose other API without Vite and they are used by @nuxt/font. I wasn't sure what Vite version range should be, so for now, I just made it as "vite": "*".

@netlify
Copy link

netlify bot commented Sep 25, 2025

Deploy Preview for fontless ready!

Name Link
🔨 Latest commit 3a8f79b
🔍 Latest deploy log https://app.netlify.com/projects/fontless/deploys/68d4f4630247e90008829f4c
😎 Deploy Preview https://deploy-preview-645--fontless.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.08%. Comparing base (e5e4cbc) to head (3a8f79b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #645   +/-   ##
=======================================
  Coverage   54.08%   54.08%           
=======================================
  Files          11       11           
  Lines         710      710           
  Branches       89       89           
=======================================
  Hits          384      384           
  Misses        326      326           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hi-ogawa hi-ogawa marked this pull request as ready for review September 25, 2025 07:52
@hi-ogawa hi-ogawa requested a review from danielroe as a code owner September 25, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant