feat: Add the option to disable codescan #245
Conversation
|
Why do we need this? |
So that the entire game doesn't get locked out from users when they have issues with code scans, like today for example when there was an active pop, but it died immediately after an update and everyone stopped playing because they were unable to join the game because Bod and Gilles are not available to manually purge the cached cdn. |
|
hey, I was available and I purged |
I had to ping you to get it purged until we deal with this issue, this option should stay on stationhub. |
|
also should probably stay in further until the steam release so we double make sure that codescans work properly on linux and mac |
| } | ||
|
|
||
| private string GetFolderName(string version) | ||
| public static string GetFolderName(string version, IEnvironmentService environmentService) |
There was a problem hiding this comment.
is envieronmentServicebeing injected now? I'm not familiar with this codebase. Where was it getting it from before?
There was a problem hiding this comment.
I think almost all pages use envieronmentService for one reason or another. I've just decided to make this function static and public, so I don't have to rewrite this logic elsewhere.
| IMsBox<string> msgBox = MessageBoxBuilder.CreateMessageBox( | ||
| MessageBoxButtons.YesNo, | ||
| "Warning", | ||
| "For security reasons, we recommend you never disable the codescan feature unless you're trying to play on older servers that are no longer supported.\n Are you sure you want to proceed?" |
There was a problem hiding this comment.
even if you are trying to play on older servers, this should not be recommended. I think the text should be
For security reasons, we recommend you never disable the codescan feature unless you understand what you are doing and you trust the server you are trying to play on.\n Are you sure you want to proceed?
3 participants
Gives a warning to users every time they open stationhub that codescan is disabled as well.