feat: add support for creating multiple roles #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the ability to support the creation of multiple roles to this module. Due to the fact that you can only have one OIDC provider per URL, this module fails with a 409 error, like the below: ``` Error: error creating IAM OIDC Provider: EntityAlreadyExists: Provider with url https://token.actions.githubusercontent.com already exists. ``` This feature is desired in the potential scenario where one wants to create separate plan and apply roles in the same account. To address this, we add an input variable to control whether we create a `aws_iam_openid_connect_provider` resource or reference an existing one using a data source. This data source was added in the AWS provider version `4.0`, so this also includes changing the provider requirements to that version. Finally, this changes the README to include generated docs from `terraform-docs` as that seemed like the easiest method to update them. I hope this is acceptable.
Owner
|
This is great, thanks again! I'll get this merged and released today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to support the creation of multiple roles to this
module. Due to the fact that you can only have one OIDC provider per
URL, this module fails with a 409 error, like the below:
This feature is desired in the potential scenario where one wants to
create separate plan and apply roles in the same account.
To address this, we add an input variable to control whether we create
a
aws_iam_openid_connect_providerresource or reference an existingone using a data source. This data source was added in the AWS provider
version
4.0, so this also includes changing the provider requirementsto that version.
Finally, this changes the README to include generated docs from
terraform-docsas that seemed like the easiest method to updatethem. I hope this is acceptable.