F# hw 9 #12
Open
F# hw 9 #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurii-litvinov
suggested changes
Jun 6, 2018
lastSteps/lastSteps/LazyAsync.fs
Outdated
| member v.Get() = | ||
| Monitor.Enter lockObject | ||
| if res.IsNone then | ||
| res <- Some <| supplier() |
There was a problem hiding this comment.
И тут в supplier может произойти исключение, которое никто не ловит, монитор остаётся захваченным, дедлок. Есть библиотечная функция lock, которая справляется лучше. Ещё, кстати, имеет смысл прочитать про double-checked locking: https://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html --- такое решение, как у Вас, достаточно хорошо для нашего недокурса по параллельному программированию, но заставляет потоки выстраиваться в очередь на мониторе и убивает весь профит от многопоточности.
lastSteps/Tests/LazyAsync.fs
Outdated
| let res = ans.[0] | ||
| for i in 1..n - 1 do | ||
| ans.[i] |> should equal res | ||
| printf "Ok" |
There was a problem hiding this comment.
Лучше разбить на несколько тестов, с нормальными названиями
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.