Using new Service object instead of deprecated execution_path #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In selenium 4.9.1 which this repo is using at the moment, a message pops up about execution_path being deprecated: DeprecationWarning: executable_path has been deprecated, please pass in a Service object In newer versions of selenium this code doesn't work at all so it should be changed to using the new syntax
Contributor
Author
|
I think you must bump the selenium version in the Dockerfile now to 4.11.0 at least😅, 4.11.2 is the latest |
Owner
|
Maybe you're right. It was wrong and didn't work on CI. I misunderstood my CI. Reverted. |
Contributor
Author
|
May I ask is there something keeping you from upgrading the selenium version? in my tests this syntax works with selenium >=4.11.0 But if you need to keep this version I can rewrite the commit using |
Owner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In selenium 4.9.1 which this repo is using at the moment, a message pops up about execution_path being deprecated: DeprecationWarning: executable_path has been deprecated, please pass in a Service object
In newer versions of selenium this code doesn't work at all so it should be changed to using the new syntax