Skip to content

Conversation

@tinder-maxwellelliott
Copy link
Contributor

Also updates CI to run Bazel tests

Also updates CI to run Bazel tests
@alanzeino
Copy link
Collaborator

Very cool! We might have to modify build.sh to install bazel before the job can run, let's see if it is installed on these mac runners that github provides

@alanzeino
Copy link
Collaborator

  File "/private/var/tmp/_bazel_runner/9332cfebedfd62170f1b5b8776e50dc1/sandbox/darwin-sandbox/21/execroot/__main__/bazel-out/darwin-fastbuild/bin/FBSnapshotTestCaseTests/FBSnapshotTestCaseTests.runfiles/xctestrunner/shared/plist_util.py", line 244, in _GetPlistLibModule
    plistlib.readPlist(plist_file_path)
AttributeError: module 'plistlib' has no attribute 'readPlist'

maybe we're missing something the testrunner expects, like a dependency on plistlib installed via pip and on the PATH, possibly we can just add that to the build.sh

https://github.com/google/xctestrunner/blob/master/shared/plist_util.py#L44

@alanzeino alanzeino merged commit 6ff475b into uber:main Sep 1, 2021
@tinder-maxwellelliott tinder-maxwellelliott deleted the maxwelle/bazel_support branch September 1, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants