Skip to content

Conversation

@Pochodaydayup
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Nov 1, 2019

Deploy preview for vue-hooks ready!

Built with commit 1ec87ec

https://deploy-preview-132--vue-hooks.netlify.com

@codecov
Copy link

codecov bot commented Nov 1, 2019

Codecov Report

Merging #132 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #132   +/-   ##
=======================================
  Coverage   99.18%   99.18%           
=======================================
  Files          15       15           
  Lines         123      123           
  Branches       17       17           
=======================================
  Hits          122      122           
  Misses          1        1
Impacted Files Coverage Δ
src/useCounter.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ecb326...1ec87ec. Read the comment docs.

@u3u
Copy link
Owner

u3u commented Nov 2, 2019

🤔️ Why remove it? I remember that TS doesn't seem to correctly derive the correct return value type, so I added this.

@Pochodaydayup
Copy link
Contributor Author

Pochodaydayup commented Nov 2, 2019

@u3u yes, TS generally will return the widening type, but in this case, it doesn’t matter add typeof value or not. but I think add as const will be better because it will add readonly .

@u3u u3u self-requested a review November 2, 2019 04:00
@u3u u3u merged commit 721dfff into u3u:dev Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants