Skip to content

Conversation

@LukaJCB
Copy link
Member

@LukaJCB LukaJCB commented Oct 4, 2018

This should resolve #31

@codecov-io
Copy link

codecov-io commented Oct 4, 2018

Codecov Report

Merging #83 into master will decrease coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
- Coverage   91.09%   90.75%   -0.34%     
==========================================
  Files          63       62       -1     
  Lines         539      530       -9     
  Branches        3        3              
==========================================
- Hits          491      481      -10     
- Misses         48       49       +1
Impacted Files Coverage Δ
core/src/main/scala/cats/mtl/instances/state.scala 84.21% <0%> (-5.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c02c7f...47390c6. Read the comment docs.

@LukaJCB LukaJCB requested review from andyscott and larsrh October 5, 2018 06:53
@LukaJCB LukaJCB requested a review from SystemFw December 20, 2018 12:06
Copy link
Contributor

@andyscott andyscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the basis of a sound code change. I can't speak to the overall design change other than reading the related issue and noting that this sounds reasonable!

@LukaJCB LukaJCB merged commit 1990a06 into master Jun 20, 2019
@larsrh larsrh deleted the remove-hierarchy branch June 20, 2019 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reconsider the MonadState => ApplicativeAsk and FunctorTell implication.

4 participants